From 24fbdbd7163d7a9d6b352a4abd824112313928c0 Mon Sep 17 00:00:00 2001
From: lanceyq <1982376970@qq.com>
Date: Wed, 4 Feb 2026 17:40:19 +0800
Subject: [PATCH] [changes]Modify the code based on the AI review

---
 api/app/controllers/memory_storage_controller.py | 5 +++++
 api/app/controllers/ontology_controller.py       | 6 +++---
 api/app/repositories/memory_config_repository.py | 2 +-
 3 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/api/app/controllers/memory_storage_controller.py b/api/app/controllers/memory_storage_controller.py
index ae372d3b..0b627775 100644
--- a/api/app/controllers/memory_storage_controller.py
+++ b/api/app/controllers/memory_storage_controller.py
@@ -195,6 +195,11 @@ def update_config(
         api_logger.warning(f"用户 {current_user.username} 尝试更新配置但未选择工作空间")
         return fail(BizCode.INVALID_PARAMETER, "请先切换到一个工作空间", "current_workspace_id is None")
     
+    # 校验至少有一个字段需要更新
+    if payload.config_name is None and payload.config_desc is None and payload.scene_id is None:
+        api_logger.warning(f"用户 {current_user.username} 尝试更新配置但未提供任何更新字段")
+        return fail(BizCode.INVALID_PARAMETER, "请至少提供一个需要更新的字段", "config_name, config_desc, scene_id 均为空")
+    
     api_logger.info(f"用户 {current_user.username} 在工作空间 {workspace_id} 请求更新配置: {payload.config_id}")
     try:
         svc = DataConfigService(db)
diff --git a/api/app/controllers/ontology_controller.py b/api/app/controllers/ontology_controller.py
index 3faa889b..4e244e35 100644
--- a/api/app/controllers/ontology_controller.py
+++ b/api/app/controllers/ontology_controller.py
@@ -52,6 +52,7 @@ from app.services.ontology_service import OntologyService
 from app.core.memory.llm_tools.openai_client import OpenAIClient
 from app.core.memory.utils.validation.owl_validator import OWLValidator
 from app.services.model_service import ModelConfigService
+from app.repositories.ontology_scene_repository import OntologySceneRepository
 
 
 api_logger = get_api_logger()
@@ -785,7 +786,7 @@ async def get_scenes_simple(
         
     Examples:
         GET /scenes/simple
-        返回: {"items": [{"scene_id": "xxx", "scene_name": "场景1"}, ...]}
+        返回: {"data": [{"scene_id": "xxx", "scene_name": "场景1"}, ...]}
     """
     api_logger.info(f"Simple scene list requested by user {current_user.id}")
     
@@ -795,12 +796,11 @@ async def get_scenes_simple(
             api_logger.warning(f"User {current_user.id} has no current workspace")
             return fail(BizCode.BAD_REQUEST, "请求参数无效", "当前用户没有工作空间")
         
-        from app.repositories.ontology_scene_repository import OntologySceneRepository
         repo = OntologySceneRepository(db)
         scenes = repo.get_simple_list(workspace_id)
         
         api_logger.info(f"Simple scene list retrieved: {len(scenes)} scenes")
-        return success(data={"items": scenes}, msg="查询成功")
+        return success(data=scenes, msg="查询成功")
         
     except Exception as e:
         api_logger.error(f"Failed to get simple scene list: {str(e)}", exc_info=True)
diff --git a/api/app/repositories/memory_config_repository.py b/api/app/repositories/memory_config_repository.py
index e846e20c..acb68ba0 100644
--- a/api/app/repositories/memory_config_repository.py
+++ b/api/app/repositories/memory_config_repository.py
@@ -279,7 +279,7 @@ class MemoryConfigRepository:
             if update.config_desc is not None:
                 db_config.config_desc = update.config_desc
                 has_update = True
-            if hasattr(update, 'scene_id') and update.scene_id is not None:
+            if update.scene_id is not None:
                 db_config.scene_id = update.scene_id
                 has_update = True